Java_toolchain: Remove Java 7 compatibility mode #9450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes bazelbuild#8772. Change-Id: Ia3467b2a33ee4bfbd10cfe3f1027e292d3a967b7
|
Superseded with: #9494 |
lucamilanesio
pushed a commit
to GerritCodeReview/gerrit
that referenced
this pull request
Oct 13, 2019
This upgrade of java_tools is needed to remove Java 7 compatibility mode for java_proto_library rules. This was done in this CL: [1], that is included in java_tools release 6.0. [1] bazelbuild/bazel#9450 Bug: Issue 11102 Change-Id: Ic0043544d238ee5cc2dcaf67ff1db9d8a5397bfa
thaidn
added a commit
to tink-crypto/tink
that referenced
this pull request
Jul 14, 2020
The primary reason to drop that support is because Bazel [1] and Protobuf [2] have stopped supporting Java 7. The second reason is that nobody in the wild should rely on Java 7 any more because it was discontinued years ago. The third reason is, due to the first reason, Tink 1.4.0-rc1 and 1.4.0-rc2 were accidentally compiled with Java 8. No user, however, has complained. Remove the JAVACOPTS option. Because Tink depends on Protobuf, Tink cannot really specify which Java version it can support, but it has to use whatever version that Protobuf supports. [1] bazelbuild/bazel#9450 [2] protocolbuffers/protobuf#7306 PiperOrigin-RevId: 321114818
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8772.
Change-Id: Ia3467b2a33ee4bfbd10cfe3f1027e292d3a967b7